Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automation): reduce automation triggler frequency #790

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

ungreat
Copy link
Collaborator

@ungreat ungreat commented Nov 13, 2023

What type of PR is this?

type-enhancement

What this PR does / why we need it:

reduce trigger frequency of LOGIN_SUCCESS automation event

Which issue(s) this PR fixes:

Fixes #
#789

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@ungreat ungreat changed the base branch from main to dev/4.2.x November 13, 2023 06:29
@ungreat ungreat self-assigned this Nov 13, 2023
@LuckyPickleZZ
Copy link
Collaborator

PR title

@ungreat ungreat changed the title Yiang reduce automation triggler frequency fix(automation): reduce automation triggler frequency Nov 13, 2023
LuckyPickleZZ
LuckyPickleZZ previously approved these changes Nov 14, 2023
Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ungreat ungreat changed the base branch from dev/4.2.x to dev/4.2.2 November 14, 2023 09:45
@ungreat ungreat dismissed LuckyPickleZZ’s stale review November 14, 2023 09:45

The base branch was changed.

@ungreat ungreat force-pushed the yiang_reduce_automation_triggler_frequency branch from a799fb6 to 4f809b5 Compare November 14, 2023 09:52
@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.2.2-bp milestone Nov 14, 2023
Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yizhouxw yizhouxw merged commit d30c188 into dev/4.2.2 Nov 14, 2023
11 checks passed
@yizhouxw yizhouxw deleted the yiang_reduce_automation_triggler_frequency branch June 16, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants