Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-security): regex column recognization rule may suffer ReDos 2 #848

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

smallsheeeep
Copy link
Contributor

What type of PR is this?

type-bug
module-data security

What this PR does / why we need it:

ODC server may suffer ReDos attack. The PR #843 still has some problem and this PR fix it.

Which issue(s) this PR fixes:

Fixes #842

Special notes for your reviewer:

Self-test passed

@smallsheeeep smallsheeeep added the type-bug Something isn't working label Nov 16, 2023
@smallsheeeep smallsheeeep added this to the ODC 4.2.2-bp milestone Nov 16, 2023
@smallsheeeep smallsheeeep self-assigned this Nov 16, 2023
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 01a9365 into dev/4.2.2 Nov 16, 2023
11 checks passed
@yhilmare yhilmare deleted the bugfix/gaoda_422_redos_defender_2 branch November 16, 2023 09:45
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants