Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit-test): read properties from .env and system environment variables #89

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

krihy
Copy link
Collaborator

@krihy krihy commented Aug 30, 2023

fix unit test properties

What type of PR is this?

type-bug

What this PR does / why we need it:

Some test information is sensitivity, but test case need it , so we can put them in .env file or system environments

Which issue(s) this PR fixes:

fix properties about test case,we can put test information is sensitivity in .env file below in builds path, eg: odc/builds/.env
, or set them in system environments variables

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@krihy krihy added type-bug Something isn't working priority-high labels Aug 30, 2023
@krihy krihy self-assigned this Aug 30, 2023
@krihy krihy added this to the ODC 4.2.1 milestone Aug 30, 2023
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krihy krihy merged commit 7bc60b5 into oceanbase:dev/4.2.x Aug 30, 2023
6 checks passed
@krihy krihy deleted the yaobin_fix_unit_test_db_info branch August 30, 2023 09:00
yhilmare added a commit that referenced this pull request Sep 4, 2023
yhilmare added a commit that referenced this pull request Sep 5, 2023
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Sep 5, 2023
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Sep 5, 2023
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Sep 5, 2023
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Sep 5, 2023
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
…ables (#89)

* add .env config file

* 1. fix: read test properties from .env file and system properties

* fix .env not exits,add check properties not empty
yhilmare added a commit that referenced this pull request Jan 15, 2024
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Jan 15, 2024
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
yhilmare added a commit that referenced this pull request Jan 15, 2024
* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit-test cases

* refactor(unit-test): refact unit test cases

* Revert "fix(unit-test): read properties from .env and system environment variables (#89)"

This reverts commit 7bc60b5

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): rename properties

* refactor(unit-test): refact unit test cases

* refactor(unit-test): rerun github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-high type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants