-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(unit-test): read properties from .env and system environment variables #89
Merged
krihy
merged 3 commits into
oceanbase:dev/4.2.x
from
krihy:yaobin_fix_unit_test_db_info
Aug 30, 2023
Merged
fix(unit-test): read properties from .env and system environment variables #89
krihy
merged 3 commits into
oceanbase:dev/4.2.x
from
krihy:yaobin_fix_unit_test_db_info
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krihy
requested review from
yhilmare,
yizhouxw,
smallsheeeep and
PeachThinking
August 30, 2023 02:53
smallsheeeep
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yhilmare
added a commit
that referenced
this pull request
Sep 5, 2023
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Sep 5, 2023
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Sep 5, 2023
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Sep 5, 2023
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Sep 5, 2023
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
pushed a commit
that referenced
this pull request
Jan 15, 2024
…ables (#89) * add .env config file * 1. fix: read test properties from .env file and system properties * fix .env not exits,add check properties not empty
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
yhilmare
added a commit
that referenced
this pull request
Jan 15, 2024
* refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit-test cases * refactor(unit-test): refact unit test cases * Revert "fix(unit-test): read properties from .env and system environment variables (#89)" This reverts commit 7bc60b5 * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): rename properties * refactor(unit-test): refact unit test cases * refactor(unit-test): rerun github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix unit test properties
What type of PR is this?
type-bug
What this PR does / why we need it:
Some test information is sensitivity, but test case need it , so we can put them in .env file or system environments
Which issue(s) this PR fixes:
fix properties about test case,we can put test information is sensitivity in .env file below in builds path, eg: odc/builds/.env
, or set them in system environments variables
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: