Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .forecasts property that retrieves forecasts #32

Merged
3 commits merged into from
Mar 30, 2022
Merged

add .forecasts property that retrieves forecasts #32

3 commits merged into from
Mar 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2022

@zacharyburnett
add .forecasts property that returns a dictionary of forecasts star…
6c369c8 
…ting at each initial time for all forecast advisories in the track
@zacharyburnett
add test for forecasts
a4085be
@ghost ghost added the enhancement New feature or request label Mar 30, 2022
@ghost ghost requested a review from WPringle March 30, 2022 15:57
@ghost ghost self-assigned this Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #32 (a4085be) into main (7875928) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a4085be differs from pull request most recent head d961462. Consider uploading reports for the commit d961462 to get more accurate results

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   90.58%   90.66%   +0.08%     
==========================================
  Files          22       22              
  Lines        2060     2079      +19     
==========================================
+ Hits         1866     1885      +19     
  Misses        194      194
Impacted Files Coverage Δ
stormevents/nhc/track.py 91.31% <100.00%> (+0.24%) ⬆️
tests/test_nhc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7875928...d961462. Read the comment docs.

@ghost ghost merged commit 1a32b4a into main Mar 30, 2022
@ghost ghost deleted the feature/forecasts branch March 30, 2022 16:14
ghost pushed a commit that referenced this pull request Mar 30, 2022
@zacharyburnett
add .forecasts property that retrieves forecasts (#32)
ba6b1ff 
* add `.forecasts` property that returns a dictionary of forecasts starting at each initial time for all forecast advisories in the track

* add test for forecasts

* make forecasts a mapping of strings to dataframes

Co-authored-by: zacharyburnett <zachary.r.burnett@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WPringle WPringle Awaiting requested review from WPringle

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
observational data retrieval
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NHC forecast parsing
1 participant
@zacharyburnett