Fix typepigeon version to pre 2 & test failures due to USGS response change
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SorooshMani-NOAA
changed the title
typepigeon version to pre 2 & test failures due to USGS response change
- Fix typepigeon version to pre 2 - Fix polygon c'tor input shell array type not being 'number' - Fix reference for updated hwm response - Use better criteria for testing latest storm - Update reference for USGS flood storms test as API response is updated - Update flood event test refrence for updated USGS response - Update usgs flood events test reference for updated USGS response - Coops data within empty region explicitely return empty - 'Black' lint fix
SorooshMani-NOAA
force-pushed
the
depend/typepigeon
branch
from
9c3ae4d to
4bf8cad
Compare
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 91.10% 90.89% -0.21%
==========================================
Files 18 18
Lines 1854 1857 +3
==========================================
- Hits 1689 1688 -1
- Misses 165 169 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The coverage failure is due to different time of running tests. Sometimes there's a "realtime" storm, and sometimes the storm GIS and storm table values from NHC are different which results in hitting different parts of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59