Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trueval should use close price #176

Closed
trizin opened this issue Sep 26, 2023 · 0 comments · Fixed by #177
Closed

Trueval should use close price #176

trizin opened this issue Sep 26, 2023 · 0 comments · Fixed by #177
Labels
Type: Bug Something isn't working

Comments

@trizin
Copy link
Contributor

trizin commented Sep 26, 2023

As @KatunaNorbert pointed out trueval right now is checking the open price

DoD

Use the close price of the candle
@trizin trizin added the Type: Bug Something isn't working label Sep 26, 2023
@trizin trizin mentioned this issue Sep 26, 2023
Merged
@trizin trizin linked a pull request Sep 26, 2023 that will close this issue
#176 - trueval should use close prices #177
Merged
trizin added a commit that referenced this issue Sep 26, 2023
@trizin
#176 - trueval should use close prices (#177)
010b0f5 
* Use close price

* Update trueval tests

* Add a test for get init and end ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#176 - trueval should use close prices oceanprotocol/pdr-backend
1 participant
@trizin