-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trader bot] Add approach1 to do simplistic trading #271
Labels
Type: Enhancement
New feature or request
Comments
trentmc
changed the title
Implement naive trader bot
[trader] trader bot doesn't actually trade yet
Oct 21, 2023
trentmc
changed the title
[trader] trader bot doesn't actually trade yet
[trader] baseline trader bot doesn't actually trade yet
Oct 21, 2023
trentmc
changed the title
[trader] baseline trader bot doesn't actually trade yet
[trader bot] baseline trader bot doesn't actually trade yet
Oct 21, 2023
2 tasks
trentmc
changed the title
[trader bot] baseline trader bot doesn't actually trade yet
[Trader bot] baseline trader bot doesn't actually trade yet
Oct 21, 2023
trentmc
changed the title
[Trader bot] baseline trader bot doesn't actually trade yet
[Trader bot] Add strategy1 to do simplistic trading
Oct 21, 2023
9 tasks
trentmc
changed the title
[Trader bot] Add strategy1 to do simplistic trading
[Trader bot] Add approach1 to do simplistic trading
Oct 22, 2023
idiom-bytes
added a commit
that referenced
this issue
Nov 7, 2023
…esn't actually trade yet (#275) * first pass * cleaning up naive trader * Completing MEXC integration * Fixing CI/CD typesafe/lint/formatting errors * Making tests pass w/ a mock binance implementation, while mexc remains e2e * Fixing assert on len(settle_tokens)>1 * Fixing trader * iterating on feedback * Submitting tests although async tests for trader are currently skipping. * Making async tests for trader_agent1 pass * Adding pytest-asyncio to setup * Fixing async test_take_step * Fixing async tests such that CICD covers them * Moved get_pred_properties test over to trader_agent --------- Co-authored-by: idiom-bytes <idiom.bytes@gmail.com> Co-authored-by: Idiom <69865342+idiom-bytes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Status quo
The trader bot is implemented in predictoor/trader/trader_agent.py.
It has a
do_trade()
function.Here's what the baseline
do_trade()
currently is:The problem
Look at the bottom of
do_trade()
. It doesn't actually do any trading yet. Not even the simplest possible trading strategy: "buy if prediction is up; exit 5 min later".We expect >1 trading strategies over time.
Predictoor bots handle this by having "approach1", "approach2", etc. We could do the same for trader bots.
DoD
do_trade()
with the trading strategy: "buy if prediction is up; exit 5 min later".Related issues
The text was updated successfully, but these errors were encountered: