>50 pylint failures, in trueval and trader

[trentmc]

(venv) trentmc@tlm-macbook: ~/code/pdr-backend $ pylint pdr_backend/*
************* Module test.test_trader_agent
pdr_backend/trader/test/test_trader_agent.py:44:13: W0613: Unused argument 'check_subscriptions_and_subscribe_mock' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:70:37: W0613: Unused argument 'addr' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:70:43: W0613: Unused argument 'timestamp' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:102:24: W0613: Unused argument 'feed' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:102:30: W0613: Unused argument 'prediction' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:87:37: W0613: Unused argument 'check_subscriptions_and_subscribe_mock' (unused-argument)
pdr_backend/trader/test/test_trader_agent.py:109:22: W0612: Unused variable 'logs' (unused-variable)
pdr_backend/trader/test/test_trader_agent.py:150:29: W0613: Unused argument 'check_subscriptions_and_subscribe_mock' (unused-argument)
************* Module approach1.trader_agent1
pdr_backend/trader/approach1/trader_agent1.py:90:13: W0511: TODO - Calculate PNL (self.order - order) (fixme)
pdr_backend/trader/approach1/trader_agent1.py:59:15: C0121: Comparison 'self.exchange != None' should be 'self.exchange is not None' (singleton-comparison)
pdr_backend/trader/approach1/trader_agent1.py:75:11: C0121: Comparison 'self.order != None' should be 'self.order is not None' (singleton-comparison)
pdr_backend/trader/approach1/trader_agent1.py:106:15: C0121: Comparison 'order != None' should be 'order is not None' (singleton-comparison)
pdr_backend/trader/approach1/trader_agent1.py:6:0: C0411: standard import "from os import getenv" should be placed before "import ccxt" (wrong-import-order)
pdr_backend/trader/approach1/trader_agent1.py:7:0: C0411: standard import "from typing import Any, Dict, Tuple, Optional" should be placed before "import ccxt" (wrong-import-order)
************* Module approach1.trader_config1
pdr_backend/trader/approach1/trader_config1.py:45:12: C0121: Comparison 'self.size != None' should be 'self.size is not None' (singleton-comparison)
pdr_backend/trader/approach1/trader_config1.py:2:0: C0411: standard import "from os import getenv" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
************* Module approach1.test.test_ccxt_exchanges
pdr_backend/trader/approach1/test/test_ccxt_exchanges.py:1:0: W0611: Unused Mock imported from unittest.mock (unused-import)
************* Module approach1.test.test_trader_agent1
pdr_backend/trader/approach1/test/test_trader_agent1.py:4:0: C0411: third party import "import pytest" should be placed before "from pdr_backend.models.feed import Feed" (wrong-import-order)
pdr_backend/trader/approach1/test/test_trader_agent1.py:5:0: C0411: standard import "from unittest.mock import Mock, patch" should be placed before "import pytest" (wrong-import-order)
************* Module approach2.trader_config2
pdr_backend/trader/approach2/trader_config2.py:45:12: C0121: Comparison 'self.size != None' should be 'self.size is not None' (singleton-comparison)
pdr_backend/trader/approach2/trader_config2.py:2:0: C0411: standard import "from os import getenv" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
************* Module approach2.trader_agent2
pdr_backend/trader/approach2/trader_agent2.py:5:0: W0404: Reimport 'Tuple' (imported line 2) (reimported)
pdr_backend/trader/approach2/trader_agent2.py:50:11: C0121: Comparison 'self.portfolio == None' should be 'self.portfolio is None' (singleton-comparison)
pdr_backend/trader/approach2/trader_agent2.py:76:11: C0121: Comparison 'self.reset_cache == True' should be 'self.reset_cache is True' if checking for the singleton value True, or 'self.reset_cache' if testing for truthiness (singleton-comparison)
pdr_backend/trader/approach2/trader_agent2.py:91:23: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression)
pdr_backend/trader/approach2/trader_agent2.py:99:43: C0121: Comparison 'feeds == None' should be 'feeds is None' (singleton-comparison)
pdr_backend/trader/approach2/trader_agent2.py:108:31: C0121: Comparison 'should_close == True' should be 'should_close is True' if checking for the singleton value True, or 'should_close' if testing for truthiness (singleton-comparison)
pdr_backend/trader/approach2/trader_agent2.py:109:38: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
pdr_backend/trader/approach2/trader_agent2.py:100:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
pdr_backend/trader/approach2/trader_agent2.py:141:18: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
pdr_backend/trader/approach2/trader_agent2.py:5:0: C0411: standard import "from typing import List, Optional, Tuple" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
pdr_backend/trader/approach2/trader_agent2.py:11:0: C0411: standard import "from datetime import datetime" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
pdr_backend/trader/approach2/trader_agent2.py:13:0: C0411: third party import "import ccxt" should be placed before "from pdr_backend.trader.trader_agent import TraderAgent" (wrong-import-order)
pdr_backend/trader/approach2/trader_agent2.py:14:0: C0411: standard import "from os import getenv" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
pdr_backend/trader/approach2/trader_agent2.py:16:0: C0412: Imports from package pdr_backend are not grouped (ungrouped-imports)
pdr_backend/trader/approach2/trader_agent2.py:1:0: W0611: Unused import random (unused-import)
************* Module approach2.portfolio
pdr_backend/trader/approach2/portfolio.py:71:9: W0511: TODO - Have N open_orders, have N close_orders (fixme)
pdr_backend/trader/approach2/portfolio.py:72:9: W0511: TODO - Move from __init__(order) to open(order) (fixme)
pdr_backend/trader/approach2/portfolio.py:82:5: W0511: TODO - Only callable by portfolio (fixme)
pdr_backend/trader/approach2/portfolio.py:40:4: W0246: Useless parent or super() delegation in method '__init__' (useless-parent-delegation)
pdr_backend/trader/approach2/portfolio.py:106:14: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
pdr_backend/trader/approach2/portfolio.py:114:18: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
pdr_backend/trader/approach2/portfolio.py:2:0: C0411: standard import "from typing import Optional, Dict, List, Any" should be placed before "from pdr_backend.models.feed import Feed" (wrong-import-order)
pdr_backend/trader/approach2/portfolio.py:3:0: C0411: standard import "from enum import Enum" should be placed before "from pdr_backend.models.feed import Feed" (wrong-import-order)
pdr_backend/trader/approach2/portfolio.py:4:0: C0411: third party import "import ccxt" should be placed before "from pdr_backend.models.feed import Feed" (wrong-import-order)
pdr_backend/trader/approach2/portfolio.py:1:0: W0611: Unused Feed imported from pdr_backend.models.feed (unused-import)
pdr_backend/trader/approach2/portfolio.py:2:0: W0611: Unused Any imported from typing (unused-import)
************* Module approach2.test.test_trader_agent2
pdr_backend/trader/approach2/test/test_trader_agent2.py:117:4: W0104: Statement seems to have no effect (pointless-statement)
pdr_backend/trader/approach2/test/test_trader_agent2.py:197:11: C0121: Comparison 'result == True' should be 'result is True' if checking for the singleton value True, or 'result' if testing for truthiness (singleton-comparison)
pdr_backend/trader/approach2/test/test_trader_agent2.py:203:11: C0121: Comparison 'result == False' should be 'result is False' if checking for the singleton value False, or 'not result' if testing for falsiness (singleton-comparison)
pdr_backend/trader/approach2/test/test_trader_agent2.py:9:0: C0411: standard import "from datetime import datetime" should be placed before "import pytest" (wrong-import-order)
************* Module test.conftest
pdr_backend/trueval/test/conftest.py:55:0: W0613: Unused argument 'args' (unused-argument)
pdr_backend/trueval/test/conftest.py:55:0: W0613: Unused argument 'kwarg' (unused-argument)
************* Module test.test_trueval_agent
pdr_backend/trueval/test/test_trueval_agent.py:14:4: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:18:22: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:18:35: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent.py:27:35: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:34:42: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:45:40: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:56:38: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:67:29: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:67:42: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent.py:73:31: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:73:44: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent.py:79:33: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:79:46: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent.py:86:4: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:86:17: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent.py:100:25: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:127:19: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:152:25: W0621: Redefining name 'agent' from outer scope (line 166) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent.py:6:0: W0611: Unused TruevalAgentBase imported from pdr_backend.trueval.trueval_agent_base (unused-import)
************* Module test.test_trueval
pdr_backend/trueval/test/test_trueval.py:12:4: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
pdr_backend/trueval/test/test_trueval.py:10:0: W0613: Unused argument 'args' (unused-argument)
pdr_backend/trueval/test/test_trueval.py:18:0: W0613: Unused argument 'args' (unused-argument)
pdr_backend/trueval/test/test_trueval.py:18:0: W0613: Unused argument 'kwargs' (unused-argument)
pdr_backend/trueval/test/test_trueval.py:2:0: C0411: standard import "from unittest.mock import patch" should be placed before "from enforce_typing import enforce_types" (wrong-import-order)
pdr_backend/trueval/test/test_trueval.py:2:0: W0611: Unused patch imported from unittest.mock (unused-import)
************* Module test.test_trueval_agent_batch
pdr_backend/trueval/test/test_trueval_agent_batch.py:11:4: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent_batch.py:16:33: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent_batch.py:21:15: C0121: Comparison 'slot.cancel == False' should be 'slot.cancel is False' if checking for the singleton value False, or 'not slot.cancel' if testing for falsiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:22:15: C0121: Comparison 'slot.trueval == True' should be 'slot.trueval is True' if checking for the singleton value True, or 'slot.trueval' if testing for truthiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:16:46: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent_batch.py:25:35: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent_batch.py:30:15: C0121: Comparison 'slot.cancel == False' should be 'slot.cancel is False' if checking for the singleton value False, or 'not slot.cancel' if testing for falsiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:31:15: C0121: Comparison 'slot.trueval == False' should be 'slot.trueval is False' if checking for the singleton value False, or 'not slot.trueval' if testing for falsiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:25:48: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent_batch.py:34:37: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent_batch.py:39:15: C0121: Comparison 'slot.cancel == True' should be 'slot.cancel is True' if checking for the singleton value True, or 'slot.cancel' if testing for truthiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:40:15: C0121: Comparison 'slot.trueval == False' should be 'slot.trueval is False' if checking for the singleton value False, or 'not slot.trueval' if testing for falsiness (singleton-comparison)
pdr_backend/trueval/test/test_trueval_agent_batch.py:34:50: W0613: Unused argument 'predictoor_contract_mock' (unused-argument)
pdr_backend/trueval/test/test_trueval_agent_batch.py:43:31: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)
pdr_backend/trueval/test/test_trueval_agent_batch.py:82:19: W0621: Redefining name 'agent' from outer scope (line 109) (redefined-outer-name)

-------------------------------------------------------------------
Your code has been rated at 9.84/10 (previous run: 10.00/10, -0.16)