Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Optimize ohlcv lake-filling output #646

Closed
1 task
trentmc opened this issue Feb 20, 2024 · 0 comments · Fixed by #647
Closed
1 task

[UX] Optimize ohlcv lake-filling output #646

trentmc opened this issue Feb 20, 2024 · 0 comments · Fixed by #647
Assignees
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Feb 20, 2024

When running olcv lake-filling, eg with pdr sim, output is e.g.

2024-02-20 11:07:29,061 INFO Fetch up to 1000 pts from timestamp=1695477600000, dt=2023-09-23_14:00:00.000
2024-02-20 11:07:31,827 INFO newest_ut_value: 1695777300000
2024-02-20 11:07:31,827 INFO Fetch up to 1000 pts from timestamp=1695777600000, dt=2023-09-27_01:20:00.000
2024-02-20 11:07:34,480 INFO newest_ut_value: 1696077300000
2024-02-20 11:07:34,481 INFO Fetch up to 1000 pts from timestamp=1696077600000, dt=2023-09-30_12:40:00.000
2024-02-20 11:07:37,149 INFO newest_ut_value: 1696377300000
2024-02-20 11:07:37,149 INFO Fetch up to 1000 pts from timestamp=1696377600000, dt=2023-10-04_00:00:00.000
2024-02-20 11:07:39,702 INFO newest_ut_value: 1696677300000
2024-02-20 11:07:39,702 INFO Fetch up to 1000 pts from timestamp=1696677600000, dt=2023-10-07_11:20:00.000
2024-02-20 11:07:42,173 INFO newest_ut_value: 1696977300000
2024-02-20 11:07:42,174 INFO Fetch up to 1000 pts from timestamp=1696977600000, dt=2023-10-10_22:40:00.000
2024-02-20 11:07:44,935 INFO newest_ut_value: 1697277300000
2024-02-20 11:07:44,935 INFO Fetch up to 1000 pts from timestamp=1697277600000, dt=2023-10-14_10:00:00.000

The problem is, it's interspersed with two lines. It's so much easier for the brain to process if it's all a single line, such as:

2024-02-20 11:07:29,061 INFO Fetch up to 1000 pts from timestamp=1695477600000, dt=2023-09-23_14:00:00.000
2024-02-20 11:07:31,827 INFO Fetch up to 1000 pts from timestamp=1695777600000, dt=2023-09-27_01:20:00.000
2024-02-20 11:07:34,481 INFO Fetch up to 1000 pts from timestamp=1696077600000, dt=2023-09-30_12:40:00.000
2024-02-20 11:07:37,149 INFO Fetch up to 1000 pts from timestamp=1696377600000, dt=2023-10-04_00:00:00.000
2024-02-20 11:07:39,702 INFO Fetch up to 1000 pts from timestamp=1696677600000, dt=2023-10-07_11:20:00.000
2024-02-20 11:07:42,174 INFO Fetch up to 1000 pts from timestamp=1696977600000, dt=2023-10-10_22:40:00.000
2024-02-20 11:07:44,935 INFO Fetch up to 1000 pts from timestamp=1697277600000, dt=2023-10-14_10:00:00.000

Or the above, also including info on newest_ut_value, in the same line.

Or the above as logging INFO, and the line with newest_ut_value as logging DEBUG.

TODOs

  • Implement: "the above as logging INFO, and the line with newest_ut_value as logging DEBUG". Simplest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant