Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor predictoor approach directory structure #75

Closed
trentmc opened this issue Aug 23, 2023 · 0 comments · Fixed by #76
Closed

Refactor predictoor approach directory structure #75

trentmc opened this issue Aug 23, 2023 · 0 comments · Fixed by #76
Assignees
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Aug 23, 2023

Status quo structure

- predictoor 
  - main.py, predict.py (random)
- examples
  - models
    - main.py, predict.py (load static model)

Problems:

  • random approach doesn't specify that it's random
  • then two (!) directories down where models go
  • and it doesn't give much space for different approaches to models. Eg static model (load from file) vs dynamic model (build on-the-fly) vs other future variants

Proposed solution structure

- approach1
    - main.py, predict.py (random)
- approach2
    - main.py, predict.py (load pre-built model)
- approach3
    - main.py, predict.py (build model on-the-fly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant