Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #122: When running publisher, get errors in get_feeds() #125

Merged
merged 14 commits into from
Sep 2, 2023
Merged

Fix #122: When running publisher, get errors in get_feeds() #125

merged 14 commits into from
Sep 2, 2023

Conversation

trentmc
Copy link
Member

@trentmc trentmc commented Sep 2, 2023 •
edited
Loading

Fixes #122

Changes proposed in this PR:

  • bug fix: Make subgraph.py query feeds able to handle filters with value '', in addition to value None
  • add robustness: env.py::parse_filters() now returns a tuple of list[str], not a list of list[str]|None
  • bug fix: get_feeds() call to query_feed_contracts guarantees to pass in a str by concatenating lists
  • bug fix: subgraph.py:query_feed_contracts() wasn't adding 'owner' to feed dict, fixed it
  • bug fix: models/feed.py wasn't converting from str to int as needed. Fixed it
  • bug fix: trueval_submit_timeout shouldn't be in feed_dict or Feed. Removed it. But ensured that trueval agent still saw it
  • bug fix: feed.py::Feed property methods base() and quote() could only handle eg BTC-USDT but not BTC/USDT. Fixed it.

trentmc added 13 commits September 2, 2023 11:39
@trentmc
Tiny bug fix in predictoor.md
dee2efa
@trentmc
undo change
e911c9f
@trentmc
Make subgraph able to handle '' in addition to None filters
3a94c0e
@trentmc
parse_filters now returns a tuple of list[str], not a list of list[st…
94a7753 
…r]|None
@trentmc
bug fix: get_feeds() call to query_feed_contracts guarantees to pass …
9fb3b3c 
…in a str by concatenating lists
@trentmc
goes with previous commit
8601956
@trentmc
Update test_trueval_config in line with changes to parse_filters()
25c783d
@trentmc
feed dict was missing 'owner', add it
a707301
@trentmc
convert from str to int as needed; remove trueval_submit_timeout (sho…
30ab022 
…uldn't be in feed_dict or Feed)
@trentmc
Feed base() and quote() could only handle - but not /. Fixed it.
90afb0e
@trentmc
Back out removal of trueval_submit_timeout from feed; test dictToFeed…
84879b2 
… for both ints & strs
@trentmc
make linters happy
db7c5cd
@trentmc
fix missing 'owner' in dict in tests. Refactor owner name
d86e807
@trentmc trentmc changed the title Fix #79: When running publisher, get errors in get_feeds() Fix #122: When running publisher, get errors in get_feeds() Sep 2, 2023
@trentmc trentmc merged commit 9518939 into main Sep 2, 2023
@trentmc trentmc deleted the issue79-keyerror branch September 2, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When running publisher, get errors in get_feeds()
1 participant
@trentmc