Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#599 - Approach 4, classifier model and two stake values #613

Closed
wants to merge 94 commits into from
Closed

#599 - Approach 4, classifier model and two stake values #613

wants to merge 94 commits into from

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Feb 13, 2024 •
edited
Loading

This PR is a step towards #599

Changes proposed in this PR:

  • Rename AI model to Regression Model
  • Add Classifier Model, classifiermodel_data_factory, classifiermodel_factory and tests.
  • Add Approach 4 that returns 2 stake values one for up and one for down and tests.
  • Handle and submit 2 stake values in base predictoor agent.
  • Refactoring of other approaches and their tests for the new functions in base predictoor agent.

@trizin trizin linked an issue Feb 13, 2024 that may be closed by this pull request
[Pdr bot, sim] Implement two-sided prediction into sim_engine, pdr bot 1, pdr bot 3 #599
Closed
15 tasks
trizin added 26 commits February 13, 2024 17:14
@trizin
Rename folder
99e02b5
@trizin
Rename aimodel_ss to regressionmodel_ss
98b8f6f
@trizin
Fix imports
61b2601
@trizin
Rename and update imports
ba0118d
@trizin
Add classifier model
e80d402
@trizin
Add unit tests
6afb6b0
@trizin
Strip out other approaches
d607047
@trizin
Add classifiermodel_ss
4d41dfc
@trizin
Fix imports
617b72b
@trizin
Add classifier model to ppss.yaml
d4fc93d
@trizin
Add classifier model to predictoorss
20c00ba
@trizin
Remove redundant test
8e6f3ae
@trizin
Fixed approach
f8f3f6f
@trizin
Fix attribute
3c2e934
@trizin
Fix checks
996013e
@trizin
Add classifier model
70755c5
@trizin
Refactor classifier and regression model SS and use base class
6a67966
@trizin
Move models to their own directory
06f982e
@trizin
Fix imports
793e2f9
@trizin
Revert "Fix imports"
18a9219 
This reverts commit 793e2f9.
@trizin
Revert "Move models to their own directory"
248b231 
This reverts commit 06f982e.
@trizin
Revert "Refactor classifier and regression model SS and use base class"
7bbe744 
This reverts commit 6a67966.
@trizin
Merge branch 'main' of https://github.com/oceanprotocol/pdr-backend i…
a8a8227 
…nto issue599-predictoor-bot-enable-staking-on-both-sides
@trizin
Remove unused variable in ClassifierModelFactory
447e982
@trizin
Rename aimodel factory
0e9c972
@trizin
Fix regression model data factory import
2ae7c3d
trizin added 20 commits February 22, 2024 11:53
trentmc
trentmc reviewed Feb 23, 2024
View reviewed changes
ppss.yaml Show resolved Hide resolved
@trentmc trentmc mentioned this pull request Feb 23, 2024
Closed
15 tasks
@trentmc
Copy link
Member

trentmc commented Feb 26, 2024

Closed in lieu of PR #670. That PR took key code from this one:)

@trentmc trentmc closed this Feb 26, 2024
@trentmc trentmc deleted the issue599-predictoor-bot-enable-staking-on-both-sides branch February 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc left review comments

Assignees

@trizin trizin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pdr bot, sim] Implement two-sided prediction into sim_engine, pdr bot 1, pdr bot 3
2 participants
@trizin @trentmc