Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #688: PredictoorContract deepcopy() causes RecursionError #689

Merged
merged 23 commits into from
Feb 28, 2024
Merged

Fix #688: PredictoorContract deepcopy() causes RecursionError #689

merged 23 commits into from
Feb 28, 2024

Conversation

trentmc
Copy link
Member

@trentmc trentmc commented Feb 28, 2024

Fix #688

sylvester05
sylvester05 reviewed Feb 28, 2024
View reviewed changes
Copy link

@sylvester05 sylvester05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good job!!!

@trizin trizin merged commit 50fa66c into main Feb 28, 2024
5 checks passed
@trizin trizin deleted the issue688-recursion branch February 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvester05 sylvester05 sylvester05 left review comments

@trizin trizin trizin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug, pdr bot] PredictoorContract deepcopy() causes RecursionError
3 participants
@trentmc @trizin @sylvester05