Make sure all pdr repos are up to date #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate' of https://github.com/oceanprotocol/pdr-backend into issue5-make-sure-all-sub-repos-in-this-repo-are-up-to-date
trentmc
requested changes
Aug 2, 2023
| @@ -0,0 +1,115 @@ | |||
| import time | |||
There was a problem hiding this comment.
Please add basic tests to dfbuyer, in a similar pattern to what I did for predictoor, etc
- pdr_backend/dfbuyer/tests/test_main.py
- pdr_backend/dfbuyer/tests/test_subgraph.py
| @@ -0,0 +1,50 @@ | |||
| import json | |||
There was a problem hiding this comment.
Could we move this up a directory, to be in pdr_backend/dfbuyer.
(Maybe it's not 1:1 to before but it does reduce complexity. And it removes confusion with of having a second "utils" directory)
|
@trentmc all done! 🙌 |
trentmc
approved these changes
Aug 2, 2023
trizin
deleted the
issue5-make-sure-all-sub-repos-in-this-repo-are-up-to-date
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Changes proposed in this PR: