Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import vhost configs #108

Merged
merged 21 commits into from
May 3, 2020
Merged

Import vhost configs #108

merged 21 commits into from
May 3, 2020

Conversation

jvperrin
Copy link
Member

@jvperrin jvperrin commented May 3, 2020

This imports the vhost configs from ~staff/vhost into this repo and adds some tests for the config files to make sure they are still formatted and loading correctly when any updates are made. Unfortunately I couldn't make a schema for it since it's a custom config file format currently, but maybe in the future we can make the file a standard YAML file or something, idk.

Next steps:

  • Add a big heading in the vhost config files in the staff directory mentioning that the files are about to move as a warning so that staffers update this repo with file changes
  • Switch ocflib, etc. to switch to read from this repo (/etc/ocf) instead of the current location (NFS or ~staff userdir via the web)
  • Remove the old vhost config files from NFS so that we aren't duplicating them

Copy link
Member

@ja5087 ja5087 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, update docs

Copy link
Member

@dkess dkess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this lgtm!

@jvperrin jvperrin merged commit 03555a0 into master May 3, 2020
jvperrin added a commit to jvperrin/utils that referenced this pull request May 3, 2020
jvperrin added a commit to jvperrin/ocflib that referenced this pull request May 3, 2020
This was added in ocf/etc#108 and should be present on every host,
unlike the NFS-backed files previously. This should remove the need for
the web fallback path.
jvperrin added a commit to jvperrin/ocfweb that referenced this pull request May 3, 2020
Since ocf/etc#108 these configs are in the ocf/etc and we're switching
that to be the source of truth. I also updated some of the language here
around how quickly updates for new vhosts/apphosts/mailhosts go through
the pipeline.
@jvperrin jvperrin deleted the import-vhost-configs branch May 3, 2020 21:53
jvperrin added a commit to ocf/utils that referenced this pull request May 3, 2020
Kalissaac pushed a commit to Kalissaac/newocfdocs that referenced this pull request Mar 6, 2022
Since ocf/etc#108 these configs are in the ocf/etc and we're switching
that to be the source of truth. I also updated some of the language here
around how quickly updates for new vhosts/apphosts/mailhosts go through
the pipeline.
jyxzhang pushed a commit to ocf/utils that referenced this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants