This repository was archived by the owner on Oct 2, 2024. It is now read-only.
don't cast F2C conversion to int #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents rounding errors that show the wrong emoji when displaying temp as Celsius
kpengboy
reviewed
Sep 22, 2019
There was a problem hiding this comment.
Have you tested to make sure that this doesn't display 10 digits of (unwanted) precision when someone requests a temperature in Celsius? EDIT: nvm second inspection shows it wouldn't happen
On a larger note though, I think the organization of code in this module is flawed and bug-prone. IMO icon should require the caller to pass Fahrenheit temperatures, and color should convert Celsius to Fahrenheit before figuring out which bucket the temperature belongs in.
|
I would prefer the methodology of PR #154. (In any case though, thanks for the contribution.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents rounding errors that show the wrong emoji when displaying temp as Celsius