This repository was archived by the owner on Oct 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Replace flask dev server with python wsgi server #166
Open
fydai
wants to merge
1
commit into
master
Choose a base branch
from
threading-attempt2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,18 @@ | ||
aspy.yaml==1.2.0 | ||
atomicwrites==1.3.0 | ||
cfgv==1.6.0 | ||
identify==1.4.3 | ||
mypy==0.711 | ||
mypy-extensions==0.4.1 | ||
aspy.yaml==1.3.0 | ||
cfgv==2.0.1 | ||
identify==1.4.8 | ||
mypy==0.750 | ||
mypy-extensions==0.4.3 | ||
nodeenv==1.3.3 | ||
pluggy==0.11.0 | ||
pre-commit==1.16.1 | ||
packaging==19.2 | ||
pluggy==0.13.1 | ||
pre-commit==1.20.0 | ||
py==1.8.0 | ||
pytest==4.5.0 | ||
pyparsing==2.4.5 | ||
pytest==5.3.2 | ||
requirements-tools==1.2.1 | ||
setuptools==41.0.1 | ||
toml==0.10.0 | ||
virtualenv==16.6.0 | ||
typed-ast==1.4.0 | ||
typing-extensions==3.7.4.1 | ||
virtualenv==16.7.8 | ||
wcwidth==0.1.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
celery[redis] | ||
cheroot | ||
ckuehl-upsidedown | ||
flask | ||
github3.py | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,60 @@ | ||
amqp==2.4.2 | ||
asn1crypto==0.24.0 | ||
attrs==19.1.0 | ||
billiard==3.6.0.0 | ||
amqp==2.5.2 | ||
attrs==19.3.0 | ||
billiard==3.6.1.0 | ||
cached-property==1.5.1 | ||
celery==4.3.0 | ||
certifi==2019.3.9 | ||
cffi==1.12.3 | ||
certifi==2019.11.28 | ||
cffi==1.13.2 | ||
chardet==3.0.4 | ||
cheroot==8.2.1 | ||
ckuehl-upsidedown==0.4 | ||
Click==7.0 | ||
cracklib==2.9.3 | ||
cryptography==2.6.1 | ||
cryptography==2.8 | ||
dnspython==1.16.0 | ||
Flask==1.0.3 | ||
Flask==1.1.1 | ||
github3.py==1.3.0 | ||
idna==2.8 | ||
importlib-metadata==0.13 | ||
inflect==2.1.0 | ||
importlib-metadata==1.3.0 | ||
inflect==3.0.2 | ||
irc==17.1 | ||
itsdangerous==1.1.0 | ||
jaraco.classes==2.0 | ||
jaraco.collections==2.0 | ||
jaraco.collections==2.1 | ||
jaraco.functools==2.0 | ||
jaraco.itertools==4.4.2 | ||
jaraco.logging==2.0 | ||
jaraco.stream==2.0 | ||
jaraco.text==3.0 | ||
Jinja2==2.10.1 | ||
jaraco.stream==3.0.0 | ||
jaraco.text==3.2.0 | ||
Jinja2==2.10.3 | ||
jwcrypto==0.6.0 | ||
kombu==4.5.0 | ||
ldap3==2.6 | ||
markovify==0.7.1 | ||
kombu==4.6.7 | ||
ldap3==2.6.1 | ||
markovify==0.7.2 | ||
MarkupSafe==1.1.1 | ||
more-itertools==7.0.0 | ||
ocflib | ||
more-itertools==8.0.2 | ||
ocflib==2019.11.12.16.30 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove version number |
||
pexpect==4.7.0 | ||
ply==3.11 | ||
ptyprocess==0.6.0 | ||
pyasn1==0.4.5 | ||
pyasn1==0.4.8 | ||
pycparser==2.19 | ||
pycryptodome==3.8.1 | ||
pycryptodomex==3.8.1 | ||
pycryptodome==3.9.4 | ||
pycryptodomex==3.9.4 | ||
PyMySQL==0.9.3 | ||
pysmi==0.3.4 | ||
pysnmp==4.4.9 | ||
python-dateutil==2.8.0 | ||
pytz==2019.1 | ||
PyYAML==5.1 | ||
redis==3.2.1 | ||
pysnmp==4.4.12 | ||
python-dateutil==2.8.1 | ||
pytz==2019.3 | ||
PyYAML==5.2 | ||
redis==3.3.11 | ||
requests==2.22.0 | ||
six==1.12.0 | ||
SQLAlchemy==1.3.3 | ||
six==1.13.0 | ||
SQLAlchemy==1.3.11 | ||
tempora==1.14.1 | ||
Unidecode==1.0.23 | ||
Unidecode==1.1.1 | ||
uritemplate==3.0.0 | ||
urllib3==1.25.2 | ||
urllib3==1.25.7 | ||
vine==1.3.0 | ||
Werkzeug==0.15.4 | ||
zipp==0.5.1 | ||
Werkzeug==0.16.0 | ||
zipp==0.6.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure using global variables and shared memory in this way is undefined behavior in WSGI's process model, which is why I avoided doing something similar. If this really works reliably then I'm probably OK with it, but I'd make sure to test this extra carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, which is why we can't use gunicorn for instance. I believe cheroot was picked specifically because it's implemented in Python so this kind of hack will work. Otherwise things will need to be drastically refactored in a painful way. But yeah, this is not ideal.