This repository was archived by the owner on Oct 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Add thread lock to IRC connection #90
Open
dkess
wants to merge
1
commit into
master
Choose a base branch
from
threadfix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,8 @@ def __init__( | |
self.plugins = {} | ||
self.extra_channels = set() # plugins can add stuff here | ||
|
||
self.sendmsg_lock = threading.Lock() | ||
|
||
# Register plugins before joining the server. | ||
self.register_plugins() | ||
|
||
|
@@ -249,28 +251,33 @@ def on_invite(self, connection, event): | |
return ircbot.plugin.channels.on_invite(self, connection, event) | ||
|
||
def bump_topic(self): | ||
for channel, topic in self.topics.items(): | ||
def plusone(m): | ||
return '{}: {}'.format(m.group(1), int(m.group(2)) + 1) | ||
with self.sendmsg_lock: | ||
for channel, topic in self.topics.items(): | ||
def plusone(m): | ||
return '{}: {}'.format(m.group(1), int(m.group(2)) + 1) | ||
|
||
new_topic = re.sub(r'(days since.*?): (\d+)', plusone, topic) | ||
if topic != new_topic: | ||
self.connection.topic(channel, new_topic=new_topic) | ||
new_topic = re.sub(r'(days since.*?): (\d+)', plusone, topic) | ||
if topic != new_topic: | ||
self.connection.topic(channel, new_topic=new_topic) | ||
|
||
def say(self, channel, message): | ||
# Find the length of the full message | ||
msg_len = len('PRIVMSG {} :{}\r\n'.format(channel, message).encode('utf-8')) | ||
|
||
# The message must be split up if over the length limit | ||
if msg_len > MAX_CLIENT_MSG: | ||
# Split up the full message into chunks to send | ||
msg_range = range(0, len(message), MAX_CLIENT_MSG) | ||
messages = [message[i:i + MAX_CLIENT_MSG] for i in msg_range] | ||
|
||
for msg in messages: | ||
self.connection.privmsg(channel, msg) | ||
else: | ||
self.connection.privmsg(channel, message) | ||
with self.sendmsg_lock: | ||
# Find the length of the full message | ||
msg_len = len('PRIVMSG {} :{}\r\n'.format( | ||
channel, | ||
message, | ||
).encode('utf-8')) | ||
|
||
# The message must be split up if over the length limit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we only really need to acquire the lock here. you aren't using the connection when getting the message length |
||
if msg_len > MAX_CLIENT_MSG: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can't we just simplify this logic and remove the Then we can simplify the logic further and only acquire the lock before the loop |
||
# Split up the full message into chunks to send | ||
msg_range = range(0, len(message), MAX_CLIENT_MSG) | ||
messages = [message[i:i + MAX_CLIENT_MSG] for i in msg_range] | ||
|
||
for msg in messages: | ||
self.connection.privmsg(channel, msg) | ||
else: | ||
self.connection.privmsg(channel, message) | ||
|
||
|
||
def timer(bot): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would just make this a lambda