-
Notifications
You must be signed in to change notification settings - Fork 0
Support GLM 4.6 template #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build: loudly skip tests we fail to get templates of (e.g. gated)
Fixes #4 - Fix parsing of values (nested method calls on function calls, e.g. `foo(x).bar(y)`) - Fix tool call capability detection - Tolerate `ensure_ascii` arg in `tojson` with support in Python jinja2 testing harness (supersedes google#84 - thanks @cnaples79 - & google#69 - thanks @rouseabout ),
Fixes #4 - Fix parsing of values (nested method calls on function calls, e.g. `foo(x).bar(y)`) - Fix tool call capability detection - Tolerate `ensure_ascii` arg in `tojson` with support in Python jinja2 testing harness (supersedes google#84 - thanks @cnaples79 - & google#69 - thanks @rouseabout ),
|
@ochafik Extremely nice work - would this allow |
@danielhanchen thanks! It will, but there's also work needed in llama.cpp's chat parsers and grammar generation (ongoing, e.g. ggml-org/llama.cpp#16932 and related PRs)
I created google/minja while working at Google. I no longer do, development is continuing here (and llama.cpp is now syncing minja from this repo) |
|
@ochafik Oh nice! Great work on minja as well! |
Fixes #4 (See ggml-org/llama.cpp#15904 (comment))
foo(x).bar(y))ensure_asciiarg intojsonwith support in Python jinja2 testing harness (supersedes feat(tojson): accept ensure_ascii kwarg for Jinja compatibility google/minja#84 - thanks @cnaples79 - & Add tojson.ensure_ascii (Support GLM 4 chat template) google/minja#69 - thanks @rouseabout ),