Skip to content

docs: add example of setting DSN params #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

jwilliams-ocient
Copy link
Collaborator

@jwilliams-ocient jwilliams-ocient commented Apr 11, 2023

SUMMARY

Minor documentation update. The Superset team asked for an example of adding a parameter, like TLS, to the connection string.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Co-authored-by: rmasters1 <100157128+rmasters1@users.noreply.github.com>
Copy link

@rmasters1 rmasters1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good.

@jwilliams-ocient jwilliams-ocient merged commit 30b13e5 into master Apr 12, 2023
@jwilliams-ocient jwilliams-ocient deleted the jwilliams-ocient-patch-1 branch April 12, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants