Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: sync types with @oclif/parser #67

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jul 13, 2019

This incorporates the changes from oclif/parser#53.

It's a pity that this has to be manually kept in sync. I tried coming up with a way to keep them in sync automatically by reusing the types from the other package but I couldn't think of any solutions that didn't involve big changes. Any ideas?

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #67 into master will increase coverage by 64.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #67       +/-   ##
===========================================
+ Coverage       0%   64.55%   +64.55%     
===========================================
  Files           1        5        +4     
  Lines          10      158      +148     
  Branches        2       35       +33     
===========================================
+ Hits            0      102      +102     
- Misses         10       37       +27     
- Partials        0       19       +19
Impacted Files Coverage Δ
src/flags.ts 55% <ø> (ø)
src/main.ts 61.53% <0%> (ø)
src/util.ts 38.88% <0%> (ø)
src/command.ts 78.75% <0%> (ø)
src/index.ts 35.71% <0%> (+35.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f5223...795f6c4. Read the comment docs.

@RasPhilCo
Copy link
Contributor

Thanks! Let's do this for now to fix those types errors and keep thinking on a better way.

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@RasPhilCo RasPhilCo changed the title Sync Definition type with @oclif/parser fix: sync types with @oclif/parser Jul 15, 2019
@RasPhilCo RasPhilCo merged commit 2a5f0b5 into oclif:master Jul 15, 2019
@frangio frangio deleted the flag-default-type branch July 15, 2019 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants