fix: failed flag parsing error

oclif · Jan 25, 2023 · d3e975f · d3e975f
1 parent 2c6d0cd
commit d3e975f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/src/parser/errors.ts b/src/parser/errors.ts
@@ -5,7 +5,7 @@ import {renderList} from '../cli-ux/list'
 import * as chalk from 'chalk'
 import {OptionFlag, Flag} from '../interfaces'
 import {uniq} from '../config/util'
-import {Arg, ArgInput, BooleanFlag, CLIParseErrorOptions} from '../interfaces/parser'
+import {Arg, ArgInput, CLIParseErrorOptions} from '../interfaces/parser'
 
 export {CLIError} from '../errors'
 
@@ -96,13 +96,6 @@ export class FlagInvalidOptionError extends CLIParseError {
   }
 }
 
-export class FailedFlagParseError extends CLIParseError {
-  constructor(flag: BooleanFlag<any> | OptionFlag<any>, errMsg: string) {
-    const message = `Parsing --${flag.name} \n\t${errMsg}`
-    super({parse: {}, message})
-  }
-}
-
 export class ArgInvalidOptionError extends CLIParseError {
   constructor(arg: Arg<any>, input: string) {
     const message = `Expected ${input} to be one of: ${arg.options!.join(', ')}`

diff --git a/src/parser/parse.ts b/src/parser/parse.ts
@@ -1,5 +1,5 @@
 /* eslint-disable no-await-in-loop */
-import {ArgInvalidOptionError, CLIError, FailedFlagParseError, FlagInvalidOptionError} from './errors'
+import {ArgInvalidOptionError, CLIError, FlagInvalidOptionError} from './errors'
 import {ArgToken, BooleanFlag, FlagToken, OptionFlag, OutputArgs, OutputFlags, ParserInput, ParserOutput, ParsingToken} from '../interfaces/parser'
 import * as readline from 'readline'
 import {isTruthy, pickBy} from '../util'
@@ -282,7 +282,8 @@ export class Parser<T extends ParserInput, TFlags extends OutputFlags<T['flags']
 
       return flag.parse ? await flag.parse(input, this.context, flag) : input
     } catch (error: any) {
-      throw new FailedFlagParseError(flag, error.message)
+      error.message = `Parsing --${flag.name} \n\t${error.message}\nSee more help with --help`
+      throw error
     }
   }