Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowStdin with no input #1046

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

k-capehart
Copy link
Contributor

  • do not throw an error if a flag with allowStdin='only' is immediately followed by another flag
  • include a new test

closes forcedotcom/cli#2811

@mdonnalley mdonnalley changed the base branch from main to mdonnalley/1046 April 8, 2024 18:19
@mdonnalley mdonnalley merged commit 79af27b into oclif:mdonnalley/1046 Apr 8, 2024
2 checks passed
@mdonnalley
Copy link
Contributor

Thanks @k-capehart for the fix 🏆

I just merged this into a separate branch so all the integration tests can run. Once those pass, I'll merge that to main

mdonnalley added a commit that referenced this pull request Apr 8, 2024
…ately followed by another flag (#1046) (#1047)

Co-authored-by: Kyle Capehart <kyleacapehart@gmail.com>
@k-capehart
Copy link
Contributor Author

@mdonnalley Thank you! There is also a small issue with the documentation that I listed at the bottom of the issue. I wasn't sure how to address that though, because it's formatted correctly in the terminal, just not on developer.salesforce.com. Just making sure that's on someone's radar as well.

@mdonnalley
Copy link
Contributor

@k-capehart Thanks for the reminder - I just made a work item on our internal tracker for it. Should be addressed fairly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'sf org login sfdx-url --sfdx-url-stdin` fails if an extra flag is given
2 participants