Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add param to runHook to capture errors #617

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

mdonnalley
Copy link
Contributor

Adds new captureErrors parameter to Config.runHook. If it's true, errors from hooks will be captured and returned to the caller; if it's false or undefined, all errors will be thrown

Fixes #515
Fixes oclif/oclif#1083

@W-12514447@

@peternhale peternhale merged commit 7e7ca96 into main Feb 10, 2023
@peternhale peternhale deleted the mdonnalley/hooks-errors branch February 10, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling this.exit() from a hook does nothing - regression in oclif 2+ Hooks are not working properly
2 participants