Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve flag validation #712

Merged
merged 4 commits into from
Jun 26, 2023
Merged

fix: improve flag validation #712

merged 4 commits into from
Jun 26, 2023

Conversation

WillieRuemmele
Copy link
Contributor

@W-13157931@

improves flag validation to prevent a flag being read as a flag value

note: I was unable to get this linked and building through my cli. I took a TDD approach instead and wrote the UTs first, and then fixed them

test/parser/parse.test.ts Show resolved Hide resolved
test/parser/parse.test.ts Outdated Show resolved Hide resolved
@shetzel
Copy link
Contributor

shetzel commented Jun 26, 2023

QA: ✅
current behavior: sf package:version:create:list -v -s Success --> "No authorization information found for -s"
new behavior: ~/dev/salesforcecli/plugin-packaging/bin/dev package:version:create:list -v -s Success --> "Flag --target-dev-hub expects a value"

@shetzel shetzel merged commit 1efb4f3 into main Jun 26, 2023
13 checks passed
@shetzel shetzel deleted the wr/flagValidation branch June 26, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants