fix: warn about ts-node and node 20 #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/config/ts-node.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| /* eslint-disable complexity */ | |||
There was a problem hiding this comment.
I don't think this is required - it passed linting for me locally
src/execute.ts
Outdated
| @@ -34,7 +34,7 @@ import {settings} from './settings' | |||
| * | |||
| * @example For CJS dev.js | |||
| * ``` | |||
| * #!/usr/bin/env ts-node | |||
| * #!/usr/bin/env -S node --loader ts-node/esm --no-warnings=ExperimentalWarning | |||
There was a problem hiding this comment.
I'll defer to you, but all of this ESM stuff is new to me... but I would've expected the CJS to remain the same?
WillieRuemmele
previously approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts-nodeis being used to executebin/dev.jsand node is >= 20ts-nodecannot be usedFixes #817
@W-14270164@