-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cache stdin #935
fix: cache stdin #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with one question about globals.
bf01850
to
b2bea84
Compare
QA notes: setup: linked this branch of oclif/core into plugin-auth and plugin-telemetry authUrl:
🟢 stdin is cached in telemetry enabled (with debug mode) ignore the
telemetry disabled (single parser call, was working before):
UPDATE: fixed
both telemetry and plugin-auth were able to get the value, couldn't track the call where it resolves to nothing. 🟢 |
Currently, flags and args read from stdin are lost whenever
Parser.parse
is called multiple times. This PR caches the value read from stdin so thatParser.parse
can be called multiple times.This PR also:
allowStdin: 'only'
are no longer required to have-
provided as the value (it's assumed)@W-14954770@
forcedotcom/cli#2690