Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Typed arguments #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Typed arguments #66

wants to merge 2 commits into from

Conversation

dhleong
Copy link

@dhleong dhleong commented Nov 30, 2019

See oclif/oclif#301

Instead of doing args as const we can do name: "name" as const to ensure the name is kept; if that's omitted then you still get a map type for the args property. Non-string arg types can be inferred from the results of parser functions or default values.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @dhleong to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #66 into master will decrease coverage by 91.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #66       +/-   ##
==========================================
- Coverage   91.38%   0.00%   -91.39%     
==========================================
  Files          11       1       -10     
  Lines         325      29      -296     
  Branches       86      14       -72     
==========================================
- Hits          297       0      -297     
- Misses         12      29       +17     
+ Partials       16       0       -16     
Impacted Files Coverage Δ
src/validate.ts 0.00% <0.00%> (-96.88%) ⬇️
src/util.ts
src/screen.ts
src/deps.ts
src/help.ts
src/flags.ts
src/list.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ae12f...8656a85. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant