Fix completion for subcommands

[jrevillard]

fixes #9

This modification make mandatory the bash-completion installation as it depends on __ltrim_colon_completions and _get_comp_words_by_ref.

I removed the embedded __ltrim_colon_completions because _get_comp_words_by_refis too big to be embedded.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @jrevillard to sign the Salesforce.com Contributor License Agreement.

[G-Rath]

@RasPhilCo anything I can do to help get this landed? It'd be a great improvement to have for the heroku cli :)

[RasPhilCo]

@G-Rath have you tested it out? PR looks good but I don't have time to do a full implementation before the holidays but trust your testing.

[G-Rath]

@RasPhilCo applying it to heroku.bash - it seems to work fine and as I'd expect:

I've not used a lot of the commands to the point of knowing them in enough detail to easy check they've all got their flags and the behaviours are working, but feel free to give me a list of situations you'd like me to try out if you have anything you'd like tested :)

One thing of note is that the heroku autocomplete file seems to be custom - it's got analytics & sources commands from a file in $HEROKU_AC_COMMANDS_PATH - I had to add this to get it working:

local commands="$(cat $HEROKU_AC_COMMANDS_PATH)"

[G-Rath]

Oh but it does seem that for suggestions after : it lists just the subcommands, which can look a little confusing:

i.e in the above for pg, it's actually suggesting pg:backup, pg:restore, etc.

I think this is good enough to ship, but might be worth a follow-up issue to improve it if possible.

[G-Rath]

Can confirm it works for sub-sub-commands 🎉

[RasPhilCo]

@jrevillard @G-Rath Great, thanks! And have a nice holiday!

[jrevillard]

Great, thanks @RasPhilCo @G-Rath!

[G-Rath]

@RasPhilCo cheers, you too!

@jrevillard thanks for this!

[oclif-bot]

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v0.3.0
• v0.3.0

Your semantic-release bot 📦🚀

[RodEsp]

@RasPhilCo @G-Rath @jrevillard why was __ltrim_colon_completions() removed here if it is still being used?

As far as I can tell this makes autocompletion for any oclif CLI dependent on the user installing bash-completion but I don't see that anywhere in oclif repos or documentation. Am I missing something?