Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install on windows bash #34

Merged
merged 4 commits into from
Dec 17, 2020
Merged

feat: install on windows bash #34

merged 4 commits into from
Dec 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2019

updated tests to use .to.throws, added some logic for empty strings

@ghost ghost requested a review from RasPhilCo October 29, 2019 14:29
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #34 into master will increase coverage by 2.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   84.67%   86.92%   +2.24%     
==========================================
  Files           4        4              
  Lines         124      130       +6     
  Branches       17       19       +2     
==========================================
+ Hits          105      113       +8     
+ Misses          9        8       -1     
+ Partials       10        9       -1
Impacted Files Coverage Δ
src/commands/autocomplete/index.ts 90.9% <ø> (ø) ⬆️
src/base.ts 80% <100%> (+16.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2afb0f...7f9c31a. Read the comment docs.

src/base.ts Outdated Show resolved Hide resolved
@RasPhilCo RasPhilCo changed the title Have windows fail gracefully, based on PR #7 feat: install on windows bash Dec 17, 2020
@RasPhilCo RasPhilCo merged commit 4ca20e5 into master Dec 17, 2020
@RasPhilCo RasPhilCo deleted the fix-windows-bash-wr branch December 17, 2020 19:02
oclif-bot added a commit that referenced this pull request Dec 17, 2020
# [0.3.0](v0.2.1...v0.3.0) (2020-12-17)

### Bug Fixes

* completion for subcommands ([#126](#126)) ([30b2857](30b2857)), closes [#9](https://github.com/oclif/issues/9)
* **zsh:** update zsh autocomplete to work with default settings ([#92](#92)) ([b9e8e7b](b9e8e7b)), closes [#91](#91)

### Features

* install on windows bash ([#34](#34)) ([4ca20e5](4ca20e5))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants