Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use inquirer #566

Merged
merged 5 commits into from
Mar 21, 2024
Merged

feat: use inquirer #566

merged 5 commits into from
Mar 21, 2024

Conversation

mdonnalley
Copy link
Contributor

Use @inquirer/confirm instead of ux module to prompt user for matching command.

This fixes issue with exit code not being set if stdin is closed (Fixes #266). However the prompt will now wait the entire 10 second timeout to close even if stdin is closed.

@jshackell-sfdc We will want to include this in the sf release notes: See this comment.

@W-15205956@

@shetzel
Copy link
Contributor

shetzel commented Mar 21, 2024

sf vrsion -> answer y ✅
sf vrsion -> answer n ✅
echo y | sf vrsion -> ✅
echo n | sf vrsion -> ✅

@shetzel shetzel merged commit 821cf95 into main Mar 21, 2024
8 checks passed
@shetzel shetzel deleted the mdonnalley/inquirer branch March 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin hides failure of command if stdin is closed
2 participants