fix: handle spaces in node bin path #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here:
forcedotcom/cli#2564
plugin-plugins v4 will always perform a check to ensure a plugin exists in npm (
npm show <plugin> dist-tags
), since it uses the bundled npm instead of the global one it requires to call it using node (so it tries to get the path to node and path to npm-cli.js).on plugin-plugins v3 this check would only happen if you tried to install a plugin and:
@
but
await this.npmHasPackage(unfriendly)
was always silently failing on windows (prob on mac/linux too) if the path to node contains spaces.plugin-plugins/src/plugins.ts
Line 93 in 5ba86b5
v4 made
npmHasPackage
thrown on not found:plugin-plugins/src/plugins.ts
Lines 125 to 126 in 76ea070
This PR fixes the error caused on windows when the path to the node binary contains spaces.