Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use native spawn, new inquirer #788

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: use native spawn, new inquirer #788

merged 2 commits into from
Apr 16, 2024

Conversation

mshanemc
Copy link
Member

No description provided.

mdonnalley
mdonnalley previously approved these changes Apr 16, 2024
View reviewed changes
@mshanemc mshanemc merged commit a53ff7a into main Apr 16, 2024
7 checks passed
@mshanemc mshanemc deleted the sm/windows-spawn branch April 16, 2024 21:06
@mshanemc
Copy link
Member Author

QA: did manually on windows.

never good a definitive "spawn ran the --autocomplete" command, but did prove that not having the {shell:true} would cause the error, and that it did not throw when the line was included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonnalley mdonnalley mdonnalley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @mdonnalley @svc-cli-bot