Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show publish date on --verbose #425

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

  • Show publish dates and latest when using --verbose
  • Bold headers
  • Dim plugin info

Before

Screenshot 2024-05-07 at 10 09 59 AM

After

Screenshot 2024-05-07 at 10 09 43 AM

Fixes #419
@W-15664257@

@mshanemc
Copy link
Member

mshanemc commented May 7, 2024

QA:

sf plugins link this into sf
✅ it's clear my CLI is not latest
✅ a very old user plugin shows that it was public 942 days ago. 😄

📓 @salesforce/cli/2.41.4 published 13 days ago (Tue Apr 23 2024) (latest is 2.39.6)
I think I'm ok with this being red? I'm usually on nightly but most people probably aren't.

❓ how do you feel about this PR changing the --json output?

[downgrade to stable, user-install plugin-org to yesterday's release]
✅ warnings
✅ no warning here org 4.1.8 (user) published 1 days ago (Mon May 06 2024)

[switch to an older plugin-org]
❌ org 4.0.1 (user) published 1 days ago (Mon May 06 2024) (latest is 4.1.8) <-- that's the wrong date for that version

[uninstall plugin-org and install via sf plugins install https://github.com/salesforcecli/plugin-org]
✅ in this case, pjson version on main is correct because that's latest?

[uninstall plugin-org and install via sf plugins install https://github.com/salesforcecli/plugin-org#341c60ac3514c436aa8a1fd7431703e622c88ae4]
org 3.5.1 (user) published 1 days ago (Mon May 06 2024) (latest is 4.1.8) that's definitely a wrong datestamp for when that version happened.

❓ if oclif officially supports "install from gh" should those appear different in sf plugins or sf version.

Copy link
Member

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see qa notes

@mdonnalley
Copy link
Contributor Author

❓ how do you feel about this PR changing the --json output?

I suspect that few people are depending on the json output here, especially since it's not easy to work with (It's just the human readable output put into a json array). If you think we should major version, then I'd recommend switching to a more usable json output, e.g. {name: org, type: user, version: 3.5.1} instead of org 3.5.1 (user).

❓ if oclif officially supports "install from gh" should those appear different in sf plugins or sf version.

I could go either way but I'm leaning towards waiting until someone asks for it

@mshanemc
Copy link
Member

mshanemc commented May 8, 2024

QA notes:
✅ dates are correct now for npm and gh based installs

@mshanemc mshanemc merged commit f608c37 into main May 8, 2024
8 checks passed
@mshanemc mshanemc deleted the mdonnalley/publish-dates branch May 8, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--verbose should show publish dates
2 participants