-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reloading libs loaded using {'serie': true} "consumes" files list #160
Comments
Oh you're right, thanks for the debug! |
Happy to help! It's a great library! On Wed, Apr 8, 2015 at 11:18 PM, Olivier Combe notifications@github.com
|
Fixed! :) |
Thanks, will check it out 👍 |
There is no new release yet since I'll be making more commits tonight |
This bug is still present. I get 'File type could not be determined. undefined' when accessing UI state that is previously loaded. |
Are you sure it's the same problem ? |
When I load UI router state first time, everything is ok, but when I access it second time it throws 'File type could not be determined. undefined'. This is probably because all required files are loaded and ocLazyLoad tries to load empty list. Everything works, it just throws error in console (when debug: true) is set. |
How is this closed?? |
Check this plnkr: http://plnkr.co/edit/oRj4EggNZLgfOQxASawi?p=preview
Look at the console output when navigating via "go to other" and "go to index". After the first navigation, you will notice that module.files has become empty. It appears that ocLazyLoad when used with the serie:true config option consumes the file list instead of cloning it for internal use.
This has created issues for us with ocLazyLoad trying to reload empty/undefined files.
The text was updated successfully, but these errors were encountered: