Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading libs loaded using {'serie': true} "consumes" files list #160

Closed
JohannesRudolph opened this issue Apr 8, 2015 · 9 comments
Closed
Labels

Comments

@JohannesRudolph
Copy link

Check this plnkr: http://plnkr.co/edit/oRj4EggNZLgfOQxASawi?p=preview

Look at the console output when navigating via "go to other" and "go to index". After the first navigation, you will notice that module.files has become empty. It appears that ocLazyLoad when used with the serie:true config option consumes the file list instead of cloning it for internal use.

This has created issues for us with ocLazyLoad trying to reload empty/undefined files.

@ocombe ocombe added the bug label Apr 8, 2015
@ocombe
Copy link
Owner

ocombe commented Apr 8, 2015

Oh you're right, thanks for the debug!

@JohannesRudolph
Copy link
Author

Happy to help! It's a great library!

On Wed, Apr 8, 2015 at 11:18 PM, Olivier Combe notifications@github.com
wrote:

Oh you're right, thanks for the debug!


Reply to this email directly or view it on GitHub
#160 (comment).

@ocombe ocombe closed this as completed in 6a5d3d4 Apr 9, 2015
@ocombe
Copy link
Owner

ocombe commented Apr 9, 2015

Fixed! :)

@JohannesRudolph
Copy link
Author

Thanks, will check it out 👍

@ocombe
Copy link
Owner

ocombe commented Apr 9, 2015

There is no new release yet since I'll be making more commits tonight

@ghost
Copy link

ghost commented May 20, 2015

This bug is still present. I get 'File type could not be determined. undefined' when accessing UI state that is previously loaded.

@ocombe
Copy link
Owner

ocombe commented May 20, 2015

Are you sure it's the same problem ?

@ghost
Copy link

ghost commented May 20, 2015

When I load UI router state first time, everything is ok, but when I access it second time it throws 'File type could not be determined. undefined'. This is probably because all required files are loaded and ocLazyLoad tries to load empty list. Everything works, it just throws error in console (when debug: true) is set.

@yogiswar1987
Copy link

How is this closed??
I see the same error in debug every time i navigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants