Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue whem text is specified as direct child inside oclazyload directive #168

Closed
vlad-nica opened this issue Apr 21, 2015 · 1 comment · Fixed by #240
Closed

Issue whem text is specified as direct child inside oclazyload directive #168

vlad-nica opened this issue Apr 21, 2015 · 1 comment · Fixed by #240
Labels
bug

Comments

@vlad-nica
Copy link

As you requested, here is the issue :)
If you put some simple text inside the element that uses oclazyload directive, you get "Syntax error, unrecognized expression: [Inner text]". See http://plnkr.co/edit/a9rTl5TgvdWGKXWenMRO?p=preview
This doesn't happen if you place an html element as child to the oclazyload directive div.
Not sure if is a real problem as this is not a real using scenario ... but still I was thinking to make you aware of this. :)
@ocombe ocombe added the bug label Apr 21, 2015
@ocombe ocombe closed this as completed in 8900e49 May 29, 2015
@ocombe
Copy link
Owner

ocombe commented May 29, 2015

Ok, it's fixed, thanks for the report :)

joaovieira pushed a commit to joaovieira/ocLazyLoad that referenced this issue Sep 24, 2015
[Directive] Compile original contents after dependency is loaded.
a48e3ce 
fixes ocombe#168
fixes ocombe#194
This was referenced Sep 24, 2015
Merged
Closed
ocombe added a commit that referenced this issue Oct 1, 2015
@ocombe
Merge pull request #240 from joaovieira/master
ca047fd 
fix: directive compile original contents after dependency is loaded.
Fixes #168 
Fixes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Directive] Compile original contents after dependency is loaded. joaovieira/ocLazyLoad
2 participants
@ocombe @vlad-nica