-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiation fails when invoke name is Object function (toString, toLocaleString,...) #184
Labels
Comments
Waiting for the PR, thanks :) |
martinratinaud
added a commit
to I-We/ocLazyLoad
that referenced
this issue
May 21, 2015
Done, but very quickly, when do you plan to merge it ? |
Once I've had the time to test it, probably tonight |
Awesome, although, I don't manage to run |
martinratinaud
added a commit
to I-We/ocLazyLoad
that referenced
this issue
May 21, 2015
Not really, but you can add a test if you like, it's always appreciated :) |
martinratinaud
added a commit
to I-We/ocLazyLoad
that referenced
this issue
May 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
trying to register a component with a reserved name like in
will produce the error below
To prevent this, in function
registerInvokeList
, we should use!regInvokes[moduleName][type].hasOwnProperty(invokeList)
instead ofangular.isUndefined(regInvokes[moduleName][type][invokeList])
I will do a PR soon.
Thanks for this awesome module
The text was updated successfully, but these errors were encountered: