Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directives inside ocLazyLoad directive not compiling #80

Closed
vlad-nica opened this issue Nov 4, 2014 · 8 comments
Closed

Directives inside ocLazyLoad directive not compiling #80

vlad-nica opened this issue Nov 4, 2014 · 8 comments
Labels

Comments

@vlad-nica
Copy link

Hi,

I noticed that directives that are placed inside an element that defines ocLazyLoad directive are not compiling.

View:

<div data-oc-lazy-load="[{ name: 'testModule', files: [ '/bundles/SomeBundle' ] }]"> 
    <div ng-controller="TestController">
         {{testString}}
         <div greetings></div>
    </div>
</div>

Debugger:

ocLazyLoad.fileLoaded /bundles/SomeBundle
ocLazyLoad.componentLoaded ["testModule", "register", "TestController"]
ocLazyLoad.componentLoaded ["testModule", "directive", "greetings"]
ocLazyLoad.moduleReloaded testModule 

The testString get's displayed (defined in controller) but the directive's controller never gets fired.

Thanks!

@ocombe
Copy link
Owner

ocombe commented Nov 4, 2014

Was it in the DOM before the lazy loading, or is it loaded after ?

@vlad-nica
Copy link
Author

Loaded after, as a template for a state/ui-view. I can not resolve the dependencies inside my states config because I defined a generic set of routes (like in MVC frameworks).

@ocombe
Copy link
Owner

ocombe commented Nov 5, 2014

Okay, I'll try to take a look at it. A plunkr would help a lot if you can.

@vlad-nica
Copy link
Author

I wasn't able to create a plunkr, but I created a demo app so that you can inspect the problem here: http://deiweb.net/ocLazyLoad

Thanks!

@vlad-nica
Copy link
Author

Problem is not solved. Directives are still not compiled.

@ocombe
Copy link
Owner

ocombe commented Nov 8, 2014

Did you take the file from the src folder (not the dist), in master (this one: https://github.com/ocombe/ocLazyLoad/blob/master/src/ocLazyLoad.js)?
I haven't pushed the files in dist yet.

@vlad-nica
Copy link
Author

I've made the same change as in 61fd4dd pull request, earlier today and the only thing that was fixed was the error about duplicate loading of directives. But the compiling is still not done in the first place.

@ocombe ocombe reopened this Nov 8, 2014
@ocombe
Copy link
Owner

ocombe commented Nov 8, 2014

Oh yes sorry, I added the wrong bug id in the commit, the PR was not supposed to fix that one. Thanks for checking, I still need to fix this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants