Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular 1.6 compatibility #380

Merged
merged 1 commit into from
Feb 1, 2017
Merged

angular 1.6 compatibility #380

merged 1 commit into from
Feb 1, 2017

Conversation

alexan
Copy link
Contributor

@alexan alexan commented Feb 1, 2017

No description provided.

@alexan alexan mentioned this pull request Feb 1, 2017
@ocombe
Copy link
Owner

ocombe commented Feb 1, 2017

Hello, thanks for the PR.
Just one question, does this remove compatibility with previous versions of angular ?

@alexan
Copy link
Contributor Author

alexan commented Feb 1, 2017

Thanks for the quick reply.
The fixes are backwards compatible and use standard promise methods instead of deprecated .success and .error.
The migration is documented here: https://docs.angularjs.org/guide/migration#-http-

@ocombe
Copy link
Owner

ocombe commented Feb 1, 2017

Ah perfect thanks, I'm not using angular 1 anymore, so I haven't had the opportunity to test it with 1.6

@ocombe ocombe merged commit 17d372f into ocombe:master Feb 1, 2017
@alexan
Copy link
Contributor Author

alexan commented Feb 1, 2017

thanks for accepting. Will you push a new version to npm?

@ocombe
Copy link
Owner

ocombe commented Feb 3, 2017

I just released 1.1.0, I think I did it right, I haven't published a new version on this repo for ages, let me know if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants