Implement to_string_lossy() #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The attached pull request implements
to_string_lossy()for Expression to provide a shell command string equivalent for the cmd pipeline (where possible). This should mostly address Issue #79 and Issue #89 and I've gone with theto_string_lossy()method name suggested in Issue #89 rather thanimpl Displayas I think that this is clearer that this is a lossy conversion. That being said the implementation does its best to capture relatively complex cmd pipelines correctly (including multiple levels of pipe, i/o redirections, manipulating env variables and directory changes - see the embedded docs for examples).As this relies heavily on UNIX shell syntax it is only enabled for
#[cfg(unix)]