-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgui_widgets.cpp missing header inclusion? (Linux) #2054
Comments
git pull + a new build => everything is ok : issue fixed, thanks 👍 The issue can be closed. |
Thanks @ebachard for the detailed report. I'm not sure to understand why your proposed patch is removing the I wasn't aware of MSVC not actually defining |
@ocornut : in fact, I provided a diff (I thought you are used to read patch language ;-) ), but it was only a workaround description. Apologies if I was not clear. |
I read patch language, but your diff REMOVE the include from one of the block and add it to the other:
To answer your question: "is there a problem for you to include stdint.h everywhere ?" any include in imgui.h that we can avoid is best to avoid. |
If you prefer, and to avoid confusion, I can edit my post, and either remove the diff, or post one with the include outside ? |
There's no need as the include was added in the imgui_widgets.cpp file. |
Hello,
After a resync with Dear ImGui 1.64, I got a build breakage on Linux (x86_64, SDL2 + OpenGL3)
Shorted log says " intptr_t was not declared in this scope" (see the full log at the bottom)
Same issue tested with both:
In the full log, you'll see that I'm using:
Same breakage occurs with -std=c99 (gcc) and g++ -std=c++11, -std=c++14 and -std=c++17 options.
Workaround : add #include <stdint.h> in imgui_widgets.cpp, solves the issue, but trying to figure out what exactly happened lead me in imgui.h, where there is the following macro (see below).
BTW : shouldn't it be 201100L ?
In fact, I'd love to keep Dear ImGui source code unmodified, and build it directly (no patch, to simplify miniDart maintainability).
Searching a bit, I found one interesting link : https://developercommunity.visualstudio.com/content/problem/120156/-cplusplus-macro-still-defined-as-pre-c11-value.html
And after some tries, and FYI, what works for me is :
Question : is there a problem for you to include stdint.h everywhere ? Most of linux distributions provide c++11 and there are probably guards in stdint.h imho, but I can be wrong.
Waiting for your opinion :-)
Last but not least, the full log:
The text was updated successfully, but these errors were encountered: