Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any other alternative to column limits imposed in the newest version? #3037

Closed
gallickgunner opened this issue Feb 23, 2020 · 2 comments
Closed

Comments

@gallickgunner
Copy link

gallickgunner commented Feb 23, 2020

Hello ocornut. I just read the changelog and found that the number of columns have been limited between 1-64. Just wanted to know, Is there any other alternative for it? Are you planning to remove columns API from the future versions or something, what's the future plan?

Since my file dialog uses a column-based design, as shown in the screenshot,instead of pure vertical list based (purely aesthetical I guess) It's entirely possible to exceed 64 columns depending on the amount of files and directories present in a specific folder and the size of the dialog itself. Thanks.

test3

@ocornut
Copy link
Owner

ocornut commented Feb 23, 2020

Hello,

  1. My initial intent was to make the Columns API call into the upcoming Tables API (New Tables API (alpha available for testing) #2957), which has a limitation of 64 columns for various reasons (which could be lifted down the line). However when I tried to implement this Columns to Tables wrapper I found that Columns has many sublte odd/specific glitches that may be difficult or unhealthy to try to replicate "as-is" using the Tables API, so I may drop that idea and leave Columns as-is, and document them as "old API, prefer to use tables". Either way, the columns api won't be removed soon, if ever.

  2. On your specific use case: since you are seemingly using one cell par column (submitting vertically before going to the next column) what you are doing could also be achieved by positioning the cursor and altering the clip-rect. The extra benefit you get from Columns is the resizing, which we should aim to provide other primitives for (Splitter #319). I think it would also be good if we made it easier and more natural to implement your use case even without using the columns api.

I haven't totally dropped the idea of the "Columns to Tables wrapper" though, but right now it seems unlikely. I'll keep this issue open for a while, because I'd like to think about (2) and I'm still working on Tables. Depending on the outcome I may keep the Columns API as-is and remove the assert introduced in the last version.

ocornut added a commit that referenced this issue Apr 2, 2020
…preemptively limited to 64 columns with an assert. (#3037, #125)

Essentially reverting 9d44406.
@ocornut
Copy link
Owner

ocornut commented Apr 2, 2020

Hello @gallickgunner ,
After some consideration I have decided to undo that change since it is unlikely I would be able to provide a perfect Columns>Table API transition.
Removed this assert now.

@ocornut ocornut closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants