Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugged wrapped text layout in 1.89 #5919

Closed
xefinity opened this issue Nov 25, 2022 · 1 comment
Closed

Bugged wrapped text layout in 1.89 #5919

xefinity opened this issue Nov 25, 2022 · 1 comment

Comments

@xefinity
Copy link

Version/Branch of Dear ImGui:

Version: 1.89.1
Branch: master

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_opengl3.cpp (GLES2) + custom touch handling
Compiler: Clang 12 (bundled with Android NDK r23b)
Operating System: Android 10

My Issue/Question:

While testing my custom touch handling, I encountered a bug with TextWrapped rendering. If it is wrapped and scrolled past first line, then it starts rendering under other widgets from second line. It looks like to be caused by commit e0330c1, because after reverting it, I didn't encounter any issues with wrapped text rendering.

Screenshots/Video
Before reverting commit:
Before reverting commit

After reverting commit:
After reverting commit

Standalone, minimal, complete and verifiable example:

Scroll any TextWrapped past first line in demo windows (for example, in Console example).

@ocornut ocornut changed the title Commit e0330c1 causes bugged wrapped text rendering on Android with GLES2 Bugged wrapped text layout in 1.89 Nov 28, 2022
ocornut added a commit that referenced this issue Nov 28, 2022
… is above the clipping region. Regression added in 1.89. (#5720, #5919)

+ Update version marker
@ocornut
Copy link
Owner

ocornut commented Nov 28, 2022

Thank you for finding this.
I have pushed the fix bd96f6e + a basic regression test in ocornut/imgui_test_engine@7eb6f2a#diff-842989679e695d3a9befb980ce84c7a7e8575d5ad8ed4ef56bed32f6dbfb6596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants