Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Dawn source code breaks WGPU Backend. #8009

Closed
blitz-research opened this issue Sep 22, 2024 · 1 comment
Closed

Latest Dawn source code breaks WGPU Backend. #8009

blitz-research opened this issue Sep 22, 2024 · 1 comment

Comments

@blitz-research
Copy link

Version/Branch of Dear ImGui:

Version 1.91.2, Branch: master

Back-ends:

imgui_impl_wgpu.cpp

Compiler, OS:

NA

Full config/build information:

No response

Details:

The latest Dawn source code breaks the WGPU backend (again).

Strings now need to be encapsulated in a WGPUStringView which is a breaking change. The WGSL shader source descriptor's type name has changed so I've updated that too, although this isn't strictly speaking a breaking change yet.

I'll make a PR for this too using this issue number.

Screenshots/Video:

No response

Minimal, Complete and Verifiable Example code:

No response

@ocornut
Copy link
Owner

ocornut commented Sep 23, 2024

Fixed by 7f81fbc. Thanks!

@ocornut ocornut closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants