Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in synced table default column size #8045

Closed
mattftw opened this issue Oct 8, 2024 · 2 comments
Closed

Regression in synced table default column size #8045

mattftw opened this issue Oct 8, 2024 · 2 comments

Comments

@mattftw
Copy link

mattftw commented Oct 8, 2024

Version/Branch of Dear ImGui:

1.91.3

Back-ends:

example_win32_directx9

Compiler, OS:

Windows 10 + MSVC2022

Full config/build information:

Dear ImGui 1.91.3 (19130)
--------------------------------
sizeof(size_t): 4, sizeof(ImDrawIdx): 2, sizeof(ImDrawVert): 20
define: __cplusplus=199711
define: _WIN32
define: _MSC_VER=1938
define: _MSVC_LANG=201402
--------------------------------
io.BackendPlatformName: imgui_impl_win32
io.BackendRendererName: imgui_impl_dx9
io.ConfigFlags: 0x00000003
 NavEnableKeyboard
 NavEnableGamepad
io.ConfigInputTextCursorBlink
io.ConfigWindowsResizeFromEdges
io.ConfigMemoryCompactTimer = 60.0
io.BackendFlags: 0x0000000E
 HasMouseCursors
 HasSetMousePos
 RendererHasVtxOffset
--------------------------------
io.Fonts: 1 fonts, Flags: 0x00000000, TexSize: 512,64
io.DisplaySize: 1264.00,761.00
io.DisplayFramebufferScale: 1.00,1.00
--------------------------------
style.WindowPadding: 8.00,8.00
style.WindowBorderSize: 1.00
style.FramePadding: 4.00,3.00
style.FrameRounding: 0.00
style.FrameBorderSize: 0.00
style.ItemSpacing: 8.00,4.00
style.ItemInnerSpacing: 4.00,4.00

Details:

There seems to be a regression with the loading of synced instances.
Somewhere between 1.89.2 and 1.91.3 the columns went from defaulting to an appropriate size, to defaulting to extremely small.

See attached images.

Screenshots/Video:

1.89.2 notice how "synced instances" tables have loaded with sensible widths
1 89 2

1.91.3 notice how "synced instances" columns have loaded extremely thin
1 91 3

Minimal, Complete and Verifiable Example code:

use example_win32_directx9 example solution.

@mattftw
Copy link
Author

mattftw commented Oct 8, 2024

The bug seems to have been introduced in this commit
e648dbb

@ocornut
Copy link
Owner

ocornut commented Oct 8, 2024

Thank you for your report. I believe f3d242a should fix this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants