-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightGreen color style #1776
LightGreen color style #1776
Conversation
resync'ing always running Dear ImGui
Thank you @ebachard. I won't focus on styles right now but will look into it (also linking to #707 for reference). I think this sort of style will benefit from revamped style system to allow e.g. changing text color depending on the background (e.g. discussed in #1223, #511, #1055, etc.) PS: Note that git associate 1 PR to 1 branch so right now your PR seems to the other changes of your fork including merges. |
Apologies for the confusing PR and the mess with the merge. I probably missed something important and badly clicked somewhere ... :-/ I still don't understand why github does not propose to extract full (unified) diffs though, and if you prefer, I can create and attach a simple a diff instead. Of course, I see all the good work you do, and I can fully understand that you don't focus on styles at the moment. My idea was just both to share how to add one new style, and show one simple style I'm using since a while. Last but not least, I'm using tabs I forked from @scottmudge and I recently hit the exactly same problem you mentionned with font colors (see https://github.com/ebachard/imgui_tabs/commit/1c63e9099bad4c246787ab1e83ac59267455b03b ) for the reference. The code needs more cleanup, mainly duplicated color variables removing and so on, but it already allows to choose between 4 different styles on the fly, what is already a good user experience for people discovering ImGui and derivated code. Thanks one more time for your incredible work 👍 |
Merge remote-tracking branch 'upstream/master'
Closing this, moved the style to #707 for now. |
Hi Omar,
Just in case you are interested, I have created a simple light style, largely inspired from Traditionnal Green (some gtk+ theme on Linux). Feel free to add it to your Gui, or ... not :-). Below, a little screenshot.
Please note I'm using DroidSans , size 17, who seems to be very nice imho, but it"s just a question of taste ...
FYI, I did some little screenshots, using your nice Dark theme with miniDart, but I expect to make big steps forward during next summer and provide more serious features soon (waiting, you can have a look at https://github.com/ebachard/miniDart)