-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EGL+OpenGLES 3.0 examples #1945
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Guangli Li <guangli.li@intel.com>
Hello @guangli0510. Thanks for your PR. I don't quite understand the approach you used - you completely duplicated imgui_impl_opengl3.cpp and made no sensible change to it (the only change being a default GLSL version that can already be setup through the initialization parameter, and which you did setup in main.cpp). Therefore the entirely of the new imgui_impl_opengles3.cpp file is unnecessary. More over, none of the description/commentary were updated. It looks like the change should be:
The good news is that the simplicity of this change suggests that the recent changes to support shader variations (applied in #1938) are indeed allowing GL ES 3 to work. |
Hello @ocornut ,
The patch comment is as below:
|
0c1e5bd
to
bb6a60b
Compare
8b83e0a
to
d735066
Compare
b3b85d8
to
0755767
Compare
c817acb
to
8d39063
Compare
Signed-off-by: Guangli Li guangli.li@intel.com
(Clear this form before submitting your PR)