-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OpenGL ES 2.0 #2393
Conversation
The current code requires OpenGL ES 3.0. With the addition of a few small #ifdefs, v2.0 can be supported as well.
I just noticed the following PR also covers this issue. I suspect this patch is simpler. Not sure whether to cancel my one or not. (note that this code also requires IMGUI_IMPL_OPENGL_LOADER_CUSTOM to be set to <GLES2/gl2.h>) |
+1 |
Thanks a lot Richard,
Unfortunately right now the other PR is in a barely usable state (lots of off-topic cruft and looks like an accidental attempt to hide the signal inside maximum amount of noise). I am a surprised that just commenting out the VAO code makes it work, I must misunderstand GL but haven't dug into it, anyway it is great that we have a second and explicit confirmation about it! I've got the right amount of information in this PR to proceed forward.
Could you clarify which implementation do or do not support ES 3.0? Do you think we could rework the top part of the .cpp file to detect ES2 systems the same way we attempt to detect ES3? And therefore completely bypass the
I think we should transition to a more explicit #define model like #2351 is using but at the same time do everything we can to default to the right GL header without custom defines. I'll rework this and try to make a commit soon so don't worry about tweaking the PR now, but would appreciate help on the question above. Thanks a lot! |
I’m afraid I don’t know which implementations support which version. I’m using PowerVR’s desktop SDK, which definitely only supports 2.0.
I was under the impression that Emscripten and whatever Qt includes were also restricted to 2.0, but I can’t confirm that.
I’d love to see the correct automatic header detection but I’m afraid I don’t know what the right thing to put in there is.
|
Thank you. It is currently using an explicit |
This PR extends the OpenGL backend to add support for OpenGL ES 2.0. The VAO feature the existing 3.0 backend uses is not strictly required, so can simply be #ifdef'd out in this case.
(the previous code required ES 3.0, which some desktop implementations do not support)