Fix SDL+Vulkan example when minimized #3259
Closed
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash when minimized / recover from minimized of SDL_Vulkan example by adding additional events, SDL_WINDOWEVENT_MINIMIZED and SDL_WINDOWEVENT_RESTORED
rokups
reviewed
May 25, 2020
| g_SwapChainResizeHeight = (int)event.window.data2; | ||
| g_SwapChainRebuild = true; | ||
| case SDL_WINDOWEVENT: | ||
| if (event.window.event == SDL_WINDOWEVENT_MINIMIZED) |
There was a problem hiding this comment.
Please fix indentation to be consistent with other code.
|
Hello,
Will look for another solution to this issue and try to patch the GLFW+Vulkan example which has the same issue. (PS: As pointed out above it's generally good when making a pull-request to try to conform to the local coding style. Thanks!) |
|
Hi Omar,
*<<*
- *I get a bunch of validation layer error when trying to resize to
zero.*
- *I'm not sure why you commented out the windowID compare, this is most
likely required to work with multi-viewports.*
*>>*
I don't resize to zero I define a minimum size for resizing.
My original problem was crashing on minimize or recover from minimized.
Solving that problem was including the callbacks for MINIMIZED and RESTORED
to rebuild the swapchain. Without I get the following error
*VkResult -1000001004*
I don't use multiple viewports but had that changed already in the
night here (not on git)
* case SDL_WINDOWEVENT:*
* if (event.window.event == SDL_WINDOWEVENT_MAXIMIZED)*
* {*
* printf("Maximized\n");*
* }*
* if (event.window.event == SDL_WINDOWEVENT_MINIMIZED &&
event.window.windowID == SDL_GetWindowID(window))*
* {*
* g_SwapChainResizeWidth = (int)event.window.data1;*
* g_SwapChainResizeHeight = (int)event.window.data2;*
* g_SwapChainRebuild = true;*
* }*
* if (event.window.event == SDL_WINDOWEVENT_RESTORED &&
event.window.windowID == SDL_GetWindowID(window))*
* {*
* g_SwapChainResizeWidth = (int)event.window.data1;*
* g_SwapChainResizeHeight = (int)event.window.data2;*
* g_SwapChainRebuild = true;*
* }*
* if (event.window.event == SDL_WINDOWEVENT_RESIZED &&
event.window.windowID == SDL_GetWindowID(window))*
* {*
* g_SwapChainResizeWidth = (int)event.window.data1;*
* g_SwapChainResizeHeight = (int)event.window.data2;*
* g_SwapChainRebuild = true;*
* }*
* break;*
Best Regards
Thomas Richter
…On Mon, 25 May 2020 at 11:01, omar ***@***.***> wrote:
Hello,
Thanks for reporting this.
- I get a bunch of validation layer error when trying to resize to
zero.
- I'm not sure why you commented out the windowID compare, this is
most likely required to work with multi-viewports.
Will look for another solution to this issue and try to patch the
GLFW+Vulkan example which has the same issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3259 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6WYM34SXTXWP56ANQXP73RTI6YNANCNFSM4NJD3K7Q>
.
|
ocornut
added a commit
that referenced
this pull request
May 25, 2020
ocornut
added a commit
that referenced
this pull request
May 25, 2020
# Conflicts: # examples/example_glfw_vulkan/main.cpp # examples/example_sdl_vulkan/main.cpp # examples/imgui_impl_sdl.cpp # imgui.cpp
|
Thomas,
Pushed a couple of commits to address this in master and with multi-viewports, for both GLFW and SDL. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash when minimized / recover from minimized of SDL_Vulkan example by adding additional events,
SDL_WINDOWEVENT_MINIMIZED and SDL_WINDOWEVENT_RESTORED
Thomas