Backends: Android: Added support for io.AddMouseSourceEvent(). #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As someone just asked (#6318) i thought it would be sane to merge, if this compile it very likely works. We can come back to it if we learn anything new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mouse sources to the Android backend similar to f070497 for other backends.
I am marking this as a draft for now as I can't currently test the changes properly.
It turns out the old Android phone I use for testing web stuff in mobile Chrome is far too old to run the example or even be targeted by the current version of Android Studio at all. (It's running KitKat 😅)
Unfortunately the emulator is not really suitable to properly test this change as you can only simulate touch and not pen or mouse input. (I did confirm that it at least properly identifies things as touch in the emulator, but it'd be nice to at least see it identify a Bluetooth mouse properly.)
A generous friend has promised me his old-but-still-modern Android phone, so when I get that in May I'll be able to test this change properly if someone else doesn't volunteer to test it for me before then.